From: "Ján ONDREJ (SAL)" <ondrejj@salstar.sk>
To: Alexander Graf <agraf@suse.de>
Cc: Glauber Costa <glommer@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH] unbreak booting with virtio
Date: Sat, 1 Aug 2009 09:04:55 +0200 [thread overview]
Message-ID: <20090801070455.GD2701@salstar.sk> (raw)
In-Reply-To: <C78D67C7-C0CF-48BE-AB0E-85C1F02171A0@suse.de>
On Fri, Jul 31, 2009 at 09:55:39PM +0200, Alexander Graf wrote:
>
> On 31.07.2009, at 20:19, Glauber Costa <glommer@redhat.com> wrote:
>
>> Since commit 89e671e3, extboot is broken due to wrong checksum
>>
>> The problem is that printf "\\$sum" syntax will require an octal
>> representation, so the fix I'm proposing is to convert it first.
>
> Is there no easy way to tell printf we're on decimal? I don't have a
> Linux system handy atm, but I thought \90 was in fact a 90.
>
> Either way, my only complaint would be to introduce a dependency on bc.
>> cp "$1" "$2"
>> +sum=$(echo "obase=8; $sum" | bc)
>> printf "\\$sum" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/
>> dev/null
May be it's better to use awk:
echo $sum | awk '{ printf("%c", $1) }' \
| dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/dev/null
This version accepts decimal $sum, does not need conversion to octal.
SAL
next prev parent reply other threads:[~2009-08-01 7:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 18:19 [PATCH] unbreak booting with virtio Glauber Costa
2009-07-31 19:55 ` Alexander Graf
2009-07-31 23:39 ` Glauber Costa
2009-08-01 8:23 ` Alexander Graf
2009-08-01 7:04 ` Ján ONDREJ (SAL) [this message]
2009-08-01 8:01 ` Ján ONDREJ (SAL)
2009-08-01 8:19 ` Alexander Graf
2009-08-01 8:47 ` Ján ONDREJ (SAL)
2009-08-01 8:20 ` Paolo Bonzini
2009-08-03 12:37 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090801070455.GD2701@salstar.sk \
--to=ondrejj@salstar.sk \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.