All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@openvz.org>
To: yinghai@kernel.org, mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Cyrill Gorcunov <gorcunov@openvz.org>
Subject: [rfc 2/2] x86,ioapic: throw BUG instead of NULL dereference
Date: Sat, 01 Aug 2009 11:48:00 +0400	[thread overview]
Message-ID: <20090801075435.769301745@openvz.org> (raw)
In-Reply-To: 20090801074758.502095557@openvz.org

[-- Attachment #1: x86-ioapic-NULL --]
[-- Type: text/plain, Size: 754 bytes --]

Instead of plain NULL deref we better throw error
message with a backtrace. Actually we need more
gracious error handling here. Meanwhile leave it
as is.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
 arch/x86/kernel/apic/io_apic.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux-2.6.git/arch/x86/kernel/apic/io_apic.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6.git/arch/x86/kernel/apic/io_apic.c
@@ -503,6 +503,10 @@ static void add_pin_to_irq_node(struct i
 	}
 
 	entry = get_one_free_irq_2_pin(node);
+	if (!entry) {
+		printk(KERN_ERR "can not alloc irq_pin_list\n");
+		BUG_ON(1);
+	}
 	entry->apic = apic;
 	entry->pin = pin;
 


  parent reply	other threads:[~2009-08-01  7:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01  7:47 [rfc 0/2] x86,ioapic simplification,bugfix Cyrill Gorcunov
2009-08-01  7:47 ` [rfc 1/2] x86,ioapic: introduce for_each_irq_pin helper Cyrill Gorcunov
2009-08-04 14:11   ` Ingo Molnar
2009-08-04 14:16   ` [tip:x86/apic] x86, ioapic: Introduce for_each_irq_pin() helper tip-bot for Cyrill Gorcunov
2009-08-05 10:55   ` tip-bot for Cyrill Gorcunov
2009-08-01  7:48 ` Cyrill Gorcunov [this message]
2009-08-04 14:16   ` [tip:x86/apic] x86, ioapic: Throw BUG instead of NULL dereference tip-bot for Cyrill Gorcunov
2009-08-05 10:55   ` tip-bot for Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090801075435.769301745@openvz.org \
    --to=gorcunov@openvz.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.