From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MXFa2-0001Mw-6b for mharc-grub-devel@gnu.org; Sat, 01 Aug 2009 10:29:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXFa1-0001LA-3l for grub-devel@gnu.org; Sat, 01 Aug 2009 10:29:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXFZw-0001F8-3V for grub-devel@gnu.org; Sat, 01 Aug 2009 10:29:00 -0400 Received: from [199.232.76.173] (port=50074 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXFZv-0001Ev-WB for grub-devel@gnu.org; Sat, 01 Aug 2009 10:28:56 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:58836 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MXFZv-0002Q3-6l for grub-devel@gnu.org; Sat, 01 Aug 2009 10:28:55 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MXFZs-0001EM-OX for grub-devel@gnu.org; Sat, 01 Aug 2009 14:28:53 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MXFZs-0005zo-3t for grub-devel@gnu.org; Sat, 01 Aug 2009 16:28:52 +0200 Date: Sat, 1 Aug 2009 16:28:52 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090801142852.GC22989@thorin> References: <20090801134014.GA22565@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] fix usability problem in FreeBSD loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Aug 2009 14:29:01 -0000 On Sat, Aug 01, 2009 at 03:49:15PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Aug 1, 2009 at 3:40 PM, Robert Millan wrote: > > > > There's a minor usability problem with FreeBSD loader.  E.g. if user runs > > freebsd_module first, the error message is confusing. > > > -static int kernel_type; > +static int kernel_type; /* 0 == KERNEL_TYPE_NONE */ > I would prefer either > static int kernel_type = KERNEL_TYPE_NONE; Ok. > And it would be better to use an enum here rather than defines. I'll fix that too. > + "You need to load the kernel first."); > + > if (kernel_type != KERNEL_TYPE_FREEBSD) > return grub_error (GRUB_ERR_BAD_ARGUMENT, > "only freebsd support module"); > It seems that we have a bitrot in error message styles. We should > agree on one style and use it everywhere This error message, in particular, is copied from linux.c. I think we should capitalize the first letter of a phrase every time. I'll fix the other messages in this file too. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."