From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MXG9S-0003Y3-G8 for mharc-grub-devel@gnu.org; Sat, 01 Aug 2009 11:05:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXG9Q-0003XE-T3 for grub-devel@gnu.org; Sat, 01 Aug 2009 11:05:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXG9M-0003U3-Sg for grub-devel@gnu.org; Sat, 01 Aug 2009 11:05:36 -0400 Received: from [199.232.76.173] (port=53863 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXG9M-0003Tu-M9 for grub-devel@gnu.org; Sat, 01 Aug 2009 11:05:32 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:41803 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MXG9L-00072b-VL for grub-devel@gnu.org; Sat, 01 Aug 2009 11:05:32 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MXG9K-0001G6-HO for grub-devel@gnu.org; Sat, 01 Aug 2009 15:05:30 +0000 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MXG9J-00063m-U4 for grub-devel@gnu.org; Sat, 01 Aug 2009 17:05:29 +0200 Date: Sat, 1 Aug 2009 17:05:29 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090801150529.GD23133@thorin> References: <20090801143415.GD22989@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [RFC] Don't pass filename in multiboot command line X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Aug 2009 15:05:37 -0000 On Sat, Aug 01, 2009 at 04:37:40PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > I agree with this.  But please wait a few days to give everyone a chance > > to read it. > > > > Regarding the patch: > > > > There's a much simpler way to address this.  Just add something like: > > > >  cmdline_argv = argv + 1; > >  cmdline_argc = argc - 1; > > > > at the beginning, and then use cmdline_argv and cmdline_argc instead of > > correcting the off-by-one every time. > Correcting the numbers is actually smaller part of the patch. The most > of it is to make empty commandlines to be handled correctly (this > couldn't happen previously) Either there's an extra argv member that is always present and we want to remove, or there's the possibility that the command-line is empty. AFAICS we can't have both problems. argv[0] corresponds to the filename, right? In that case, it's not possible to run multiboot without argv[0] (or at least, we shouldn't allow it). Then we can remove it unconditionally. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."