From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-input@vger.kernel.org, johannes@sipsolutions.net,
linux-wireless@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 1/2] input: Add KEY_RFKILL_ALL
Date: Sat, 1 Aug 2009 21:45:34 +0100 [thread overview]
Message-ID: <20090801204534.GA23642@srcf.ucam.org> (raw)
In-Reply-To: <1249159133.3491.13.camel@localhost.localdomain>
On Sat, Aug 01, 2009 at 01:38:53PM -0700, Marcel Holtmann wrote:
> actually I would prefer if we name this key KEY_RFKILL and not put the
> policy of ALL into the kernel. Since we wanna get rid of rfkill-input.
> That needs to be done in userspace and by users policy. If they wanna
> map that key to ALL then that is fine. If they just wanna toggle WiFi,
> then that is also fine. If the wanna have to popup some UI, that is also
> reasonable.
My reasoning was that this conceptually maps to a key that controls all
of the radios in the system - whether a single press actually kills all
of them or not is kind of irrelevent (having the simple policy in
rfkill-input works fine for this, but userspace will obviously want
something more cunning). My concern with KEY_RFKILL is that it it's not
obvious that it refers to a specific type of key - ones that purely
control wifi should still be KEY_WLAN, for instance.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-08-01 20:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 18:54 [PATCH 1/2] input: Add KEY_RFKILL_ALL Matthew Garrett
2009-08-01 18:54 ` Matthew Garrett
[not found] ` <1249152859-14769-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-08-01 18:54 ` [PATCH 2/2] rfkill: Add support for KEY_RFKILL_ALL Matthew Garrett
2009-08-01 18:54 ` Matthew Garrett
2009-08-01 20:25 ` Bastien Nocera
2009-08-01 20:41 ` Marcel Holtmann
2009-08-01 20:38 ` [PATCH 1/2] input: Add KEY_RFKILL_ALL Marcel Holtmann
2009-08-01 20:45 ` Matthew Garrett [this message]
2009-08-01 20:52 ` Marcel Holtmann
2009-08-01 20:54 ` Matthew Garrett
[not found] ` <20090801205445.GA23751-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2009-08-01 21:48 ` Marcel Holtmann
2009-08-01 21:48 ` Marcel Holtmann
[not found] ` <1249163327.3491.24.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-08-01 21:51 ` Matthew Garrett
2009-08-01 21:51 ` Matthew Garrett
[not found] ` <20090801215130.GA24201-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2009-08-01 22:11 ` Marcel Holtmann
2009-08-01 22:11 ` Marcel Holtmann
[not found] ` <1249164685.3491.28.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-08-01 22:25 ` Matthew Garrett
2009-08-01 22:25 ` Matthew Garrett
2009-08-02 7:55 ` Johannes Berg
2009-08-02 1:05 ` Henrique de Moraes Holschuh
2009-08-02 1:15 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090801204534.GA23642@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.