From: Ralf Baechle <ralf@linux-mips.org>
To: "Loïc Grenié" <loic.grenie@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Strange arch/mips/delay.c
Date: Sun, 2 Aug 2009 00:33:05 +0100 [thread overview]
Message-ID: <20090801233305.GA31392@linux-mips.org> (raw)
In-Reply-To: <9b06e8d20908011037m6b0f72cch154ed1e15bdc8938@mail.gmail.com>
On Sat, Aug 01, 2009 at 07:37:18PM +0200, Loïc Grenié wrote:
> I could not compile for mips without something similar to the
> following patch. As far as I can say __udelay and __ndelay
> are costly nops (with __ndelay not compiling at all) without
> the patch.
>
> At that point, it might be interesting to change
> the 0x00000005uLL by 0x00000045uLL and the >> 32
> by >> 36 (the precision is much better and the cost
> should be the same -- obviously there is a slightly higher
> risk of overlow).
Later versions of the kernel already contain a similar fix. I've not
propagated MIPS fixes into upstream -stable but the fixes are available
in the -stable branches of the MIPS git repository at
git://git.linux-mips.org/pub/scm/linux.git, the tarballs created from
that repository available for download on {ftp,www}.linux-mips.org or
on git.kernel.org.
Ralf
prev parent reply other threads:[~2009-08-01 23:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 17:37 Strange arch/mips/delay.c Loïc Grenié
2009-08-01 23:33 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090801233305.GA31392@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.grenie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.