Re: [PATCH] ath5k: fix missing output in monitor mode after ifconfig up

[Bob Copeland <me@bobcopeland.com>]

On Sun, Aug 02, 2009 at 12:33:26AM +0200, Joerg Albert wrote:
> Let ath5k_chan_set() call ath5k_reset() if ath5k_config() was told
> that the channel changed. This fixes the bug that we don't
> get any packets in monitor mode after:

Cool, thanks for the patch.  Just a couple of comments:

> +                              int chan_changed);

Should use bool for that.

> -       ret = ath5k_chan_set(sc, conf->channel);
> +       ret = ath5k_chan_set(sc, conf->channel,
> +                            changed & IEEE80211_CONF_CHANGE_CHANNEL);

Since this is the only place ath5k_chan_set is called, how about changing
ath5k_chan_set to unconditionally do a reset, and put the test outside?

i.e.:

        if (changed & IEEE80211_CONF_CHANGE_CHANNEL)
                ath5k_chan_set(sc, conf->channel);

Thanks!

-- 
Bob Copeland %% www.bobcopeland.com