All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Theodore Kilgore <kilgota@banach.math.auburn.edu>
Cc: Andy Walls <awalls@radix.net>, Linux Media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] to add support for certain Jeilin dual-mode cameras.
Date: Sun, 2 Aug 2009 10:33:50 +0200	[thread overview]
Message-ID: <20090802103350.19657a07@tele> (raw)
In-Reply-To: <alpine.LNX.2.00.0908011635020.26881@banach.math.auburn.edu>

On Sat, 1 Aug 2009 16:56:06 -0500 (CDT)
Theodore Kilgore <kilgota@banach.math.auburn.edu> wrote:

> Several cameras are supported here, which all share the same USB 
> Vendor:Product number when started up in streaming mode. All of these 
> cameras use bulk transport for streaming, and all of them produce
> frames in JPEG format.

Hi Theodore,

Your patch seems ok, but:

- there is no kfree(sd->jpeg_hdr). Should be in stop0().

- as there is only one vend:prod, one line is enough in gspca.txt.

May you fix this and resend?

Thanks.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

  reply	other threads:[~2009-08-02  8:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090418183124.1c9160e3@free.fr>
2009-08-01 21:56 ` [PATCH] to add support for certain Jeilin dual-mode cameras Theodore Kilgore
2009-08-02  8:33   ` Jean-Francois Moine [this message]
2009-08-02 19:12     ` Theodore Kilgore
2009-08-03  8:39       ` Jean-Francois Moine
2009-08-03 16:01         ` Theodore Kilgore
2009-08-03 17:26           ` Mauro Carvalho Chehab
2009-08-03 19:46             ` Theodore Kilgore
2009-08-03 21:59               ` Mauro Carvalho Chehab
2009-08-04  5:45                 ` Theodore Kilgore
2009-08-02 20:37     ` [PATCH] to add support for certain Jeilin dual-mode cameras. (resubmit) Theodore Kilgore
2009-08-02 13:25   ` [PATCH] to add support for certain Jeilin dual-mode cameras Alexey Klimov
2009-08-03  6:30     ` Jean-Francois Moine
2009-08-03 12:11       ` Mauro Carvalho Chehab
2009-08-04  6:51       ` Alexey Klimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090802103350.19657a07@tele \
    --to=moinejf@free.fr \
    --cc=awalls@radix.net \
    --cc=kilgota@banach.math.auburn.edu \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.