From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MXiqW-00040q-Rc for mharc-grub-devel@gnu.org; Sun, 02 Aug 2009 17:44:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXiqU-00040e-H7 for grub-devel@gnu.org; Sun, 02 Aug 2009 17:43:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXiqQ-0003yK-R8 for grub-devel@gnu.org; Sun, 02 Aug 2009 17:43:58 -0400 Received: from [199.232.76.173] (port=51953 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXiqQ-0003yC-O4 for grub-devel@gnu.org; Sun, 02 Aug 2009 17:43:54 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:38874 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MXiqQ-000758-81 for grub-devel@gnu.org; Sun, 02 Aug 2009 17:43:54 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MXiqO-0003cJ-KV for grub-devel@gnu.org; Sun, 02 Aug 2009 23:43:52 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MXiqO-00051e-1X for grub-devel@gnu.org; Sun, 02 Aug 2009 23:43:52 +0200 Date: Sun, 2 Aug 2009 23:43:52 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090802214352.GF15139@thorin> References: <1248392495.2661.208.camel@mj> <20090801150118.GB23133@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Fwd: [PATCH 1/2] Framebuffer split X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Aug 2009 21:43:59 -0000 On Sat, Aug 01, 2009 at 05:10:30PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Btw, if I understand correctly, we have a race condition right now.  As a > > bugfix it'd be better to merge this separately from the interface redesign if > > possible. > race condition? We don't even have threads Well, we have the possibility that video drivers are doing stuff in background, but that's something entirely different I had in mind. Please bear with me, I missunderstood what you wrote :-) > > Why is this chunk of code moved down?  AFAICS, this change only involves > > adding an additional layer between it and the video backend.  Does this > > make it conflict with something else? > > > I wanted to keep normal grub_printf as long as possible and after > get_mode_and_fini grub_printf may be unfunctional. Ok > >> +#define grub_video_render_target grub_video_fbrender_target > > > > If we want to rename this function, I'd rather do it all the way than > > keeping a compatibility macro.  But then, I'd also prefer if this is > > done separately from the rest (either before or after). > > > It's not about renaming but to inform includes that > grub_video_render_target is in fact grub_video_fbrender_target and so > avoid warnings and casts. I don't understand this. If we want to settle with grub_video_render_target why don't we just provide that function directly? Or is this making room for an additional layer later on? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."