From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: pcnet32@verizon.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, error27@gmail.com, corbet@lwn.net,
eteo@redhat.com, julia@diku.dk
Subject: Re: [PATCH] pcnet32: remove superfluous NULL pointer check in pcnet32_probe1()
Date: Sun, 2 Aug 2009 22:07:29 +0200 [thread overview]
Message-ID: <200908022207.29942.bzolnier@gmail.com> (raw)
In-Reply-To: <20090802.123022.148176905.davem@davemloft.net>
On Sunday 02 August 2009 21:30:22 David Miller wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Thu, 30 Jul 2009 23:19:17 +0200
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] pcnet32: remove superfluous NULL pointer check in pcnet32_probe1()
> >
> > Move the debug printk() into the proper place and remove superfluous
> > NULL pointer check in pcnet32_probe1().
> >
> > This takes care of the following entry from Dan's list:
> >
> > drivers/net/pcnet32.c +1889 pcnet32_probe1(298) warning: variable derefenced before check 'pdev'
> >
> > Reported-by: Dan Carpenter <error27@gmail.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Applied, but please CC: netdev@vger.kernel.org for all future
> network driver patches so that it gets properly tracked in
> patchwork. Thanks!
netdev@vger.kernel.org was on cc: for all patches...
http://marc.info/?l=linux-netdev&m=124898901714229&w=2
http://marc.info/?l=linux-netdev&m=124898901714236&w=2
maybe there is some problem with a patchwork setup..
next prev parent reply other threads:[~2009-08-02 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 21:19 [PATCH] pcnet32: remove superfluous NULL pointer check in pcnet32_probe1() Bartlomiej Zolnierkiewicz
2009-07-31 18:40 ` Don Fry
2009-08-02 19:30 ` David Miller
2009-08-02 20:07 ` Bartlomiej Zolnierkiewicz [this message]
2009-08-02 20:12 ` David Miller
2009-08-04 10:32 ` Bartlomiej Zolnierkiewicz
2009-08-04 13:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908022207.29942.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=eteo@redhat.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.