All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix configure script on bash 2.0
@ 2009-08-03  7:51 =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
  2009-08-03 17:46 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont @ 2009-08-03  7:51 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 98 bytes --]

   Hello,

+= seems to be a bash3ism. Use a more portable syntax.

-- 
Rémi Denis-Courmont

[-- Attachment #2: 0001-Fix-configure-script-on-bash-2.0.patch --]
[-- Type: text/plain, Size: 1681 bytes --]

From d1b4382eca8e49c56cc3dd5fb5a083dab21fa8c3 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?R=C3=A9mi=20Denis-Courmont?= <remi.denis-courmont@nokia.com>
Date: Mon, 3 Aug 2009 10:42:51 +0300
Subject: [PATCH] Fix configure script on bash 2.0

../configure: line 11885: CFLAGS+= -Werror -Wextra: command not found
../configure: line 11886: CFLAGS+= -Wno-unused-parameter: command not found
../configure: line 11887: CFLAGS+= -Wno-missing-field-initializers: command not found
../configure: line 11888: CFLAGS+= -Wdeclaration-after-statement: command not found
../configure: line 11889: CFLAGS+= -Wmissing-declarations: command not found
../configure: line 11890: CFLAGS+= -Wredundant-decls: command not found
../configure: line 11891: CFLAGS+= -Wcast-align: command not found
---
 acinclude.m4 |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/acinclude.m4 b/acinclude.m4
index 4594073..84c1081 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -15,12 +15,12 @@ AC_DEFUN([COMPILER_FLAGS], [
 		CFLAGS="-Wall -O2 -D_FORTIFY_SOURCE=2"
 	fi
 	if (test "$USE_MAINTAINER_MODE" = "yes"); then
-		CFLAGS+=" -Werror -Wextra"
-		CFLAGS+=" -Wno-unused-parameter"
-		CFLAGS+=" -Wno-missing-field-initializers"
-		CFLAGS+=" -Wdeclaration-after-statement"
-		CFLAGS+=" -Wmissing-declarations"
-		CFLAGS+=" -Wredundant-decls"
-		CFLAGS+=" -Wcast-align"
+		CFLAGS="$CFLAGS -Werror -Wextra"
+		CFLAGS="$CFLAGS -Wno-unused-parameter"
+		CFLAGS="$CFLAGS -Wno-missing-field-initializers"
+		CFLAGS="$CFLAGS -Wdeclaration-after-statement"
+		CFLAGS="$CFLAGS -Wmissing-declarations"
+		CFLAGS="$CFLAGS -Wredundant-decls"
+		CFLAGS="$CFLAGS -Wcast-align"
 	fi
 ])
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-03 17:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-03  7:51 [PATCH] Fix configure script on bash 2.0 =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2009-08-03 17:46 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.