From: Wolfram Sang <w.sang@pengutronix.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Roel Kluin <roel.kluin@gmail.com>
Subject: Re: [PATCH] powerpc: Read buffer overflow
Date: Mon, 3 Aug 2009 15:12:31 +0200 [thread overview]
Message-ID: <20090803131231.GG3154@pengutronix.de> (raw)
In-Reply-To: <19062.57005.981901.24666@cargo.ozlabs.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Mon, Aug 03, 2009 at 10:57:17PM +1000, Paul Mackerras wrote:
> Roel Kluin writes:
>
> > Check whether index is within bounds before grabbing the element.
>
> The change seems unnecessary since we only compute the address of the
> element before the bounds check, we don't actually access the
> element. I believe that is legal in C.
I've got this strange feeling of deja vu :)
http://thread.gmane.org/gmane.linux.ports.arm.kernel/63507
(I'd vote for applying it but won't mind if not)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-08-03 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 12:41 [PATCH] powerpc: Read buffer overflow Roel Kluin
2009-08-03 12:57 ` Paul Mackerras
2009-08-03 13:12 ` Wolfram Sang [this message]
2009-08-03 20:15 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2009-08-03 11:48 Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803131231.GG3154@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.