From: Benjamin Marzinski <bmarzins@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: [PATCH 2/5] multipath-tools: Log all messages
Date: Mon, 3 Aug 2009 17:00:03 -0500 [thread overview]
Message-ID: <20090803220003.GS15326@ether.msp.redhat.com> (raw)
When the log thread pulls the last message off the buffer, it sets
la->empty. However, then it returns la->empty, which means that the log is
empty, instead of 0, which means that it found a message. This means that
multipathd is not logging the last message in the buffer when the log threa
runs. This patch changes the return code, so that multipathd logs all the
messages in the buffer.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: multipath-tools/libmultipath/log.c
===================================================================
--- multipath-tools.orig/libmultipath/log.c
+++ multipath-tools/libmultipath/log.c
@@ -181,7 +181,7 @@ int log_dequeue (void * buff)
memset((void *)src, 0, len);
- return la->empty;
+ return 0;
}
/*
reply other threads:[~2009-08-03 22:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803220003.GS15326@ether.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.