From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pete Zaitcev Subject: Re: [Patch 2/3] cldcli: suppress warnings from -Wshadow Date: Mon, 3 Aug 2009 22:11:03 -0600 Message-ID: <20090803221103.6e5bd50c@redhat.com> References: <20090803195428.075142a5@redhat.com> <4A7798BA.6010906@garzik.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A7798BA.6010906@garzik.org> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Jeff Garzik Cc: Project Hail List On Mon, 03 Aug 2009 22:11:06 -0400, Jeff Garzik wrote: > I think the root cause is poorly named globals, so instead of applying > this patch, I added a "thr_" prefix to the globals 'fh' and 'udp'. > > I also fixed the other -Wshadow warnings as well, even though they were > largely harmless (variable name matched a system function name). By all means, thanks. -- Pete