From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933493AbZHECdh (ORCPT ); Tue, 4 Aug 2009 22:33:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933286AbZHECdg (ORCPT ); Tue, 4 Aug 2009 22:33:36 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:35065 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933273AbZHECdf (ORCPT ); Tue, 4 Aug 2009 22:33:35 -0400 Date: Tue, 04 Aug 2009 19:33:44 -0700 (PDT) Message-Id: <20090804.193344.71849943.davem@davemloft.net> To: chiachi@android.com Cc: john.dykstra1@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: Keep interface binding when sending packets with ipi_ifindex = 0 From: David Miller In-Reply-To: <6c039e090908041706p6f06ac55ja796ac53855e829a@mail.gmail.com> References: <6c039e090908040036j38666152y2db1d4c55529eaff@mail.gmail.com> <20090804.115701.250978139.davem@davemloft.net> <6c039e090908041706p6f06ac55ja796ac53855e829a@mail.gmail.com> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha.home.local id n753UV8B003250 From: Chia-chi Yeh (葉家齊) Date: Wed, 5 Aug 2009 08:06:25 +0800 > 2009/8/5 David Miller : >> I think we really cannot change behavior here.  If the user specifies >> "0" in ipi_ifindex we must respect that in ipc->oif.  This is an >> override, and the ability to override is the very purpose of this >> control message. >> >> Even GLIBC makes use of that case of specifying "0" in ipi_ifindex. >> We must respect it. >> >> I'm not applying any of these patches, sorry. >> > > If you treat ipi_ifindex as an override, do you want to do that in > ipi6_ifindex as well? Also, CAP_NET_RAW check for SO_BINDTODEVICE > becomes meaningless in this case. ipi_ifindex influences routing decisions, it doesn't also influence socket matching like SO_BINDTODEVICE does. That's the crucial difference. This interface index gets passed into the routing lookup and that is completely harmless to allow users to do. About ipv6 it is indeed an important issue, because apps that work now with ipv4's behavior are going to break if they care about this case when they start using ipv6. Probably the thing to do is make ipv6 work the same as ipv4. > I did not find the usage of ipi_ifindex in glibc. It would be great if > you can give me some pointers. Thanks for your help. If grep is broken on your system, I'm sorry to hear that: find . -type f | xargs egrep IP_PKTINFO Give that a try on your glibc tree. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: Keep interface binding when sending packets with ipi_ifindex = 0 Date: Tue, 04 Aug 2009 19:33:44 -0700 (PDT) Message-ID: <20090804.193344.71849943.davem@davemloft.net> References: <6c039e090908040036j38666152y2db1d4c55529eaff@mail.gmail.com> <20090804.115701.250978139.davem@davemloft.net> <6c039e090908041706p6f06ac55ja796ac53855e829a@mail.gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Content-Transfer-Encoding: base64 Cc: john.dykstra1@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: chiachi@android.com Return-path: In-Reply-To: <6c039e090908041706p6f06ac55ja796ac53855e829a@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org RnJvbTogQ2hpYS1jaGkgWWVoICjokYnlrrbpvYopIDxjaGlhY2hpQGFuZHJvaWQuY29tPg0KRGF0 ZTogV2VkLCA1IEF1ZyAyMDA5IDA4OjA2OjI1ICswODAwDQoNCj4gMjAwOS84LzUgRGF2aWQgTWls bGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0PjoNCj4+IEkgdGhpbmsgd2UgcmVhbGx5IGNhbm5vdCBj aGFuZ2UgYmVoYXZpb3IgaGVyZS4gwqBJZiB0aGUgdXNlciBzcGVjaWZpZXMNCj4+ICIwIiBpbiBp cGlfaWZpbmRleCB3ZSBtdXN0IHJlc3BlY3QgdGhhdCBpbiBpcGMtPm9pZi4gwqBUaGlzIGlzIGFu DQo+PiBvdmVycmlkZSwgYW5kIHRoZSBhYmlsaXR5IHRvIG92ZXJyaWRlIGlzIHRoZSB2ZXJ5IHB1 cnBvc2Ugb2YgdGhpcw0KPj4gY29udHJvbCBtZXNzYWdlLg0KPj4NCj4+IEV2ZW4gR0xJQkMgbWFr ZXMgdXNlIG9mIHRoYXQgY2FzZSBvZiBzcGVjaWZ5aW5nICIwIiBpbiBpcGlfaWZpbmRleC4NCj4+ IFdlIG11c3QgcmVzcGVjdCBpdC4NCj4+DQo+PiBJJ20gbm90IGFwcGx5aW5nIGFueSBvZiB0aGVz ZSBwYXRjaGVzLCBzb3JyeS4NCj4+DQo+IA0KPiBJZiB5b3UgdHJlYXQgaXBpX2lmaW5kZXggYXMg YW4gb3ZlcnJpZGUsIGRvIHlvdSB3YW50IHRvIGRvIHRoYXQgaW4NCj4gaXBpNl9pZmluZGV4IGFz IHdlbGw/IEFsc28sIENBUF9ORVRfUkFXIGNoZWNrIGZvciBTT19CSU5EVE9ERVZJQ0UNCj4gYmVj b21lcyBtZWFuaW5nbGVzcyBpbiB0aGlzIGNhc2UuDQoNCmlwaV9pZmluZGV4IGluZmx1ZW5jZXMg cm91dGluZyBkZWNpc2lvbnMsIGl0IGRvZXNuJ3QgYWxzbyBpbmZsdWVuY2UNCnNvY2tldCBtYXRj aGluZyBsaWtlIFNPX0JJTkRUT0RFVklDRSBkb2VzLg0KDQpUaGF0J3MgdGhlIGNydWNpYWwgZGlm ZmVyZW5jZS4NCg0KVGhpcyBpbnRlcmZhY2UgaW5kZXggZ2V0cyBwYXNzZWQgaW50byB0aGUgcm91 dGluZyBsb29rdXAgYW5kIHRoYXQgaXMNCmNvbXBsZXRlbHkgaGFybWxlc3MgdG8gYWxsb3cgdXNl cnMgdG8gZG8uDQoNCkFib3V0IGlwdjYgaXQgaXMgaW5kZWVkIGFuIGltcG9ydGFudCBpc3N1ZSwg YmVjYXVzZSBhcHBzIHRoYXQgd29yayBub3cNCndpdGggaXB2NCdzIGJlaGF2aW9yIGFyZSBnb2lu ZyB0byBicmVhayBpZiB0aGV5IGNhcmUgYWJvdXQgdGhpcyBjYXNlDQp3aGVuIHRoZXkgc3RhcnQg dXNpbmcgaXB2Ni4gIFByb2JhYmx5IHRoZSB0aGluZyB0byBkbyBpcyBtYWtlIGlwdjYNCndvcmsg dGhlIHNhbWUgYXMgaXB2NC4NCg0KPiBJIGRpZCBub3QgZmluZCB0aGUgdXNhZ2Ugb2YgaXBpX2lm aW5kZXggaW4gZ2xpYmMuIEl0IHdvdWxkIGJlIGdyZWF0IGlmDQo+IHlvdSBjYW4gZ2l2ZSBtZSBz b21lIHBvaW50ZXJzLiBUaGFua3MgZm9yIHlvdXIgaGVscC4NCg0KSWYgZ3JlcCBpcyBicm9rZW4g b24geW91ciBzeXN0ZW0sIEknbSBzb3JyeSB0byBoZWFyIHRoYXQ6DQoNCglmaW5kIC4gLXR5cGUg ZiB8IHhhcmdzIGVncmVwIElQX1BLVElORk8NCg0KR2l2ZSB0aGF0IGEgdHJ5IG9uIHlvdXIgZ2xp YmMgdHJlZS4NCg==