From: "sn_" <sn_@gmx.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: j6t@kdbg.org, git@vger.kernel.org
Subject: Re: [PATCH] Fix compiler warning by properly initialize failed_errno
Date: Tue, 04 Aug 2009 11:27:59 +0200 [thread overview]
Message-ID: <20090804092759.24120@gmx.net> (raw)
In-Reply-To: <7vmy6g6rj1.fsf@alter.siamese.dyndns.org>
> The potentially uninitialized use your compiler is worried about is inside
> if (cmd->pid < 0) after #ifdef/#else/#endif.
>
> (1) if not on MINGW32, we would have already assigned to failed_errno
> after fork() returns negative value to cmd->pid;
>
> (2) if on MINGW32, we would have assigned to failed_errno unconditionally
> after calling mingw_spawnvpe().
>
> so its worry is unfounded.
The worry is definatly unfounded, but I think it's still worth to apply the attached patch to get rid of the warning using the i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490) compiler. I sended a corrected version of the patch to the ml.
--
Jetzt kostenlos herunterladen: Internet Explorer 8 und Mozilla Firefox 3 -
sicherer, schneller und einfacher! http://portal.gmx.net/de/go/atbrowser
next prev parent reply other threads:[~2009-08-04 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-02 19:34 [PATCH] Fix compiler warning by properly initialize failed_errno David Soria Parra
2009-08-04 6:07 ` Junio C Hamano
2009-08-04 9:27 ` sn_ [this message]
2009-08-04 22:22 ` Junio C Hamano
2009-08-04 18:51 ` Johannes Sixt
2009-08-04 19:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804092759.24120@gmx.net \
--to=sn_@gmx.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.