From: Robert Richter <robert.richter@amd.com>
To: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ring-buffer: Fix advance of reader in rb_buffer_peek()
Date: Tue, 4 Aug 2009 18:49:28 +0200 [thread overview]
Message-ID: <20090804164927.GZ14610@erda.amd.com> (raw)
In-Reply-To: <1249044963-26878-1-git-send-email-robert.richter@amd.com>
On 31.07.09 14:56:03, Robert Richter wrote:
> When calling rb_buffer_peek() from ring_buffer_consume() and a padding
> event is returned, the function rb_advance_reader() is called
> twice. This may lead to missing samples or under high workloads to the
> warning below. This patch fixes this. If a padding event is returned
> by rb_buffer_peek() it will be consumed by the calling function now.
>
> Also, I simplified some code in ring_buffer_consume().
>
> ------------[ cut here ]------------
> WARNING: at /dev/shm/.source/linux/kernel/trace/ring_buffer.c:2289 rb_advance_reader+0x2e/0xc5()
> Hardware name: Anaheim
> Modules linked in:
> Pid: 29, comm: events/2 Tainted: G W 2.6.31-rc3-oprofile-x86_64-standard-00059-g5050dc2 #1
> Call Trace:
> [<ffffffff8106776f>] ? rb_advance_reader+0x2e/0xc5
> [<ffffffff81039ffe>] warn_slowpath_common+0x77/0x8f
> [<ffffffff8103a025>] warn_slowpath_null+0xf/0x11
> [<ffffffff8106776f>] rb_advance_reader+0x2e/0xc5
> [<ffffffff81068bda>] ring_buffer_consume+0xa0/0xd2
> [<ffffffff81326933>] op_cpu_buffer_read_entry+0x21/0x9e
> [<ffffffff810be3af>] ? __find_get_block+0x4b/0x165
> [<ffffffff8132749b>] sync_buffer+0xa5/0x401
> [<ffffffff810be3af>] ? __find_get_block+0x4b/0x165
> [<ffffffff81326c1b>] ? wq_sync_buffer+0x0/0x78
> [<ffffffff81326c76>] wq_sync_buffer+0x5b/0x78
> [<ffffffff8104aa30>] worker_thread+0x113/0x1ac
> [<ffffffff8104dd95>] ? autoremove_wake_function+0x0/0x38
> [<ffffffff8104a91d>] ? worker_thread+0x0/0x1ac
> [<ffffffff8104dc9a>] kthread+0x88/0x92
> [<ffffffff8100bdba>] child_rip+0xa/0x20
> [<ffffffff8104dc12>] ? kthread+0x0/0x92
> [<ffffffff8100bdb0>] ? child_rip+0x0/0x20
> ---[ end trace f561c0a58fcc89bd ]---
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: <stable@kernel.org>
> Signed-off-by: Robert Richter <robert.richter@amd.com>
Steven, Ingo,
should I apply the patch to my tree? Or does somebody of you wants to
apply it? I got a bug report and want to have it in a tree.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2009-08-04 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 19:51 WARNING: at kernel/trace/ring_buffer.c:2289 rb_advance_reader+0x2e/0xc5() Robert Richter
2009-07-27 21:24 ` Steven Rostedt
2009-07-31 12:56 ` [PATCH] ring-buffer: Fix advance of reader in rb_buffer_peek() Robert Richter
2009-08-04 16:49 ` Robert Richter [this message]
2009-08-04 18:07 ` Steven Rostedt
2009-07-31 13:13 ` WARNING: at kernel/trace/ring_buffer.c:2289 rb_advance_reader+0x2e/0xc5() Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804164927.GZ14610@erda.amd.com \
--to=robert.richter@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.