From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MYQPu-0000Um-Jl for mharc-grub-devel@gnu.org; Tue, 04 Aug 2009 16:15:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MYQPs-0000U9-W5 for grub-devel@gnu.org; Tue, 04 Aug 2009 16:15:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MYQPo-0000RQ-1W for grub-devel@gnu.org; Tue, 04 Aug 2009 16:15:24 -0400 Received: from [199.232.76.173] (port=52282 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MYQPn-0000RD-QQ for grub-devel@gnu.org; Tue, 04 Aug 2009 16:15:19 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:53602 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MYQPn-0006rr-AI for grub-devel@gnu.org; Tue, 04 Aug 2009 16:15:19 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MYQPj-0004lC-Nd for grub-devel@gnu.org; Tue, 04 Aug 2009 22:15:16 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MYQPg-00047g-D7 for grub-devel@gnu.org; Tue, 04 Aug 2009 22:15:12 +0200 Date: Tue, 4 Aug 2009 22:15:12 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090804201512.GA15811@thorin> References: <20090802220236.GG15139@thorin> <20090802222505.GI15139@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] nested partitions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2009 20:15:25 -0000 On Mon, Aug 03, 2009 at 12:44:37AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > Btw, does this bugfix depend on the rest of nested partition changes? > > > Actually only superficially > > + disk->partition = p->parent; > this line would be = 0; without nestpart patch. If you want I can > commit it separately. > > The following line is bogus: > > + /* In i386-pc, the id is equal to the BIOS drive number. */ > > + drive = (int) disk->id; > It shouldn't have been here at all - it was written before > introduction of biosnum. I won't resend the patch because of this but > I corrected it in my local git Please take into account the issue with pc_partition_map. Your current patch checks for it in a place where operation with non-msdos labels would still proceed. I notice the grub_device_open(0) call is wrong too, but this has nothing to do with your patch. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."