From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: Hemanth V <hemanthv@ti.com>,
spi-devel-general@lists.sourceforge.net,
linux-omap@vger.kernel.org
Subject: Re: [RESEND][PATCH 2/2] McSPI Slave and DMA,FIFO support
Date: Wed, 5 Aug 2009 11:59:27 +0300 [thread overview]
Message-ID: <20090805085927.GD7374@atomide.com> (raw)
In-Reply-To: <200907021722.02459.david-b@pacbell.net>
* David Brownell <david-b@pacbell.net> [090703 03:22]:
> On Tuesday 23 June 2009, Hemanth V wrote:
> > This patch adds support for McSPI slave and FIFO. DMA and FIFO
> > could be enabled together for better throughput.
> >
> > This has a dependency on patch
> > [RESEND][PATCH 1/2] McSPI Slave and DMA,FIFO support
>
> ... in this case I'd think they would better be part of
> a single patch.
>
> However, anything related to SPI slave support should
> be separated entirely from FIFO support.
>
> Ditto anything adding more SPI_DEBUG support.
>
> Oh, and use the BIT(n) syntax not (1 << n) in the new
> constants you define... the patch making this driver
> use that style finally went upstream.
I agree with Dave's comments. Maybe repost one more time,
then I'd actually prefer these get merged via the SPI list
once everybody's happy.
Tony
prev parent reply other threads:[~2009-08-05 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 13:54 [RESEND][PATCH 2/2] McSPI Slave and DMA,FIFO support Hemanth V
2009-07-03 0:22 ` David Brownell
2009-08-05 8:59 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805085927.GD7374@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=hemanthv@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.