From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933719AbZHEM00 (ORCPT ); Wed, 5 Aug 2009 08:26:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933527AbZHEM0Z (ORCPT ); Wed, 5 Aug 2009 08:26:25 -0400 Received: from mx2.redhat.com ([66.187.237.31]:50636 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933132AbZHEM0Y (ORCPT ); Wed, 5 Aug 2009 08:26:24 -0400 Date: Wed, 5 Aug 2009 15:26:08 +0300 From: Gleb Natapov To: Ingo Molnar Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, suresh.b.siddha@intel.com, tglx@linutronix.de, sheng@linux.intel.com, avi@redhat.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/apic] x86/apic: Enable x2APIC without interrupt remapping under KVM Message-ID: <20090805122608.GJ4764@redhat.com> References: <20090720122417.GR5638@redhat.com> <20090804133715.GA29573@elte.hu> <20090804165702.GF4764@redhat.com> <20090805121621.GA31918@elte.hu> <20090805121923.GI4764@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090805121923.GI4764@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2009 at 03:19:23PM +0300, Gleb Natapov wrote: > On Wed, Aug 05, 2009 at 02:16:21PM +0200, Ingo Molnar wrote: > > > > * Gleb Natapov wrote: > > > > > +static inline void x2apic_force_phys() > > > +{ > > > +} > > > > Sigh. Have you tested this patche and have you looked at the > > resultig compiler output? > > > I haven't looked and compiler output. What is wrong with it? > Is defining this function as #define would be batter? > Actually I made it a define initially and tested with it. Later I change it to be inline and apparently tested only with x2apic enabled. I see the problem now. Do you want it to be define or properly defined empty inline function like any other function in this code? -- Gleb.