Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

Hi,

> It is kind of working but one of the things "simplified away" is using
> the D-Bus interface even without working EF-MBDN or EF-MWIS files on
> the SIM, i.e. if the write fails then the user never finds out there
> was a notification.

Sorry I don't quite follow.  The mw_set_indicator function sets the value and 
emits the signals regardless of whether the MWIS file could be written.  Can 
you explain some more?

For setting mailbox numbers, a working EF-MBDN is required since the only 
alternative would be to store them on the filesystem.

>
> Consistently with the change to return invalid_args on D-Bus type
> mismatch, I'm attaching a diff to do the same thing for other
> interfaces we have.

Patch has been applied.

>
> You might want to add G_DBUS_METHOD_FLAG_ASYNC to SetProperty
> signature and remove mw_update declaration which is now unused.  Also
> the check in cache_info should probably be if (r < len).

Yep, yep and yep.  Thanks.

Regards,
-Denis