From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 4/4] cr_tests: Use stdout for rewrite-cr-header.sh output Date: Wed, 5 Aug 2009 09:02:57 -0500 Message-ID: <20090805140257.GC31272@us.ibm.com> References: <1249447347-26415-4-git-send-email-matthltc@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1249447347-26415-4-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matt Helsley Cc: Linux Containers List-Id: containers.vger.kernel.org Quoting Matt Helsley (matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > Instead of overwriting cr.h in the current directory write the output > of rewrite-cr-header.sh to stdout and let whoever invokes the script > decide what to do with the output. This should make it slightly > easier to test and make the script more widely usable (e.g. in user-cr). > > Signed-off-by: Matt Helsley > Cc: Linux Containers All applied, thanks. -serge > --- > rewrite-cr-header.sh | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/rewrite-cr-header.sh b/rewrite-cr-header.sh > index ffc6f62..97f39fc 100755 > --- a/rewrite-cr-header.sh > +++ b/rewrite-cr-header.sh > @@ -40,9 +40,6 @@ fi > > ################################################################################ > > -mv cr.h cr.h.bak || exit -1 > - > -( > COND='#if' > set -e > echo '/* AUTOMATICALLY GENERATED by rewrite-cr-header.sh */' > @@ -88,9 +85,3 @@ while read UNISTDH ; do > COND='#elif' > done > echo -e '#else\n#error "Architecture does not have definitons for __NR_(checkpoint|restart)"\n#endif' > -) > cr.h || { > - mv -f cr.h.bak cr.h > - exit -1 > -} > - > -rm -f cr.h.bak > -- > 1.5.6.3