From: Stephen Hemminger <shemminger@vyatta.com>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org, Rene Mayrhofer <rene@mayrhofer.eu.org>,
Richard Leitner <leitner@esys.at>
Subject: Re: [PATCH] sky2: Add a mutex around ethtools operations
Date: Wed, 5 Aug 2009 17:42:41 -0700 [thread overview]
Message-ID: <20090805174241.6c8be715@nehalam> (raw)
In-Reply-To: <4A7A0BAA.7020104@ring3k.org>
On Thu, 06 Aug 2009 07:46:02 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> As multiple sky2 devices share some of the same hardware, and ethtool
> operations are per device, access to transmit timers, eeprom access,
> coalesce, etc. should be serialized.
>
> Only tested on a single port card, as my sky2 doesn't have dual ports.
>
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
NAK.
The ethtool operations are already serialized by rtnl mutex at
higher level. See net/core/dev.c
--
prev parent reply other threads:[~2009-08-06 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 22:46 [PATCH] sky2: Add a mutex around ethtools operations Mike McCormack
2009-08-06 0:41 ` Stephen Hemminger
2009-08-06 0:42 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805174241.6c8be715@nehalam \
--to=shemminger@vyatta.com \
--cc=leitner@esys.at \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
--cc=rene@mayrhofer.eu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.