All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: mac80211 TX frame alignment
Date: Wed, 5 Aug 2009 20:57:45 +0200	[thread overview]
Message-ID: <200908052057.45715.IvDoorn@gmail.com> (raw)
In-Reply-To: <1249407436.24787.6.camel@johannes.local>

Hi,

> > Do you know if for outgoing frames the header should always
> > be 4-byte aligned?
> 
> I know that there's no alignment guarantee.
>
> > I have a bugreport from users claiming that master mode
> > is failing for rt2500pci because the beacons passed to the
> > driver are not 4-byte aligned which causes the device not
> > to send out the beacons correctly.
> > 
> > I'm just wondering if this is something that should be fixed
> > in the driver or in mac80211.
> 
> I don't think we can fix that in mac80211, since we don't know whether
> or not any alignment is required. We could align beacon frames, I
> suppose, since those are created on the fly, but not data frames.

Ok, I'll look into a patch for making sure rt2x00 aligns all frames
correctly before mapping the DMA.

Thanks,

Ivo

      reply	other threads:[~2009-08-05 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-04 17:05 mac80211 TX frame alignment Ivo van Doorn
2009-08-04 17:37 ` Johannes Berg
2009-08-05 18:57   ` Ivo van Doorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908052057.45715.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.