From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Mack <daniel@caiaq.de>
Subject: Re: [PATCH 4/5] input: gpio-keys: switch to new dev_pm_ops
Date: Thu, 6 Aug 2009 00:33:42 +0200
Message-ID: <20090805223342.GG19257@buzzloop.caiaq.de>
References: <1249496971-9019-1-git-send-email-daniel@caiaq.de> <1249496971-9019-2-git-send-email-daniel@caiaq.de> <1249496971-9019-3-git-send-email-daniel@caiaq.de> <1249496971-9019-4-git-send-email-daniel@caiaq.de> <74d0deb30908051315l43b00731yb79f7937707068ec@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1753465AbZHEWdw@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <74d0deb30908051315l43b00731yb79f7937707068ec@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: pHilipp Zabel <philipp.zabel@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org, Phil Blundell <pb@handhelds.org>, linux-input@vger.kernel.org
List-Id: linux-input@vger.kernel.org

On Wed, Aug 05, 2009 at 10:15:52PM +0200, pHilipp Zabel wrote:
> On Wed, Aug 5, 2009 at 8:29 PM, Daniel Mack<daniel@caiaq.de> wrote:
> > -static int gpio_keys_resume(struct platform_device *pdev)
> > +static int gpio_keys_resume(struct device *dev)
> > =A0{
> > - =A0 =A0 =A0 struct gpio_keys_platform_data *pdata =3D pdev->dev.p=
latform_data;
> > + =A0 =A0 =A0 struct gpio_keys_platform_data *pdata =3D dev->platfo=
rm_data;
> > =A0 =A0 =A0 =A0int i;
> >
> > - =A0 =A0 =A0 if (device_may_wakeup(&pdev->dev)) {
> > + =A0 =A0 =A0 if (device_may_wakeup(dev)) {
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0for (i =3D 0; i < pdata->nbuttons; i=
++) {
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct gpio_keys_but=
ton *button =3D &pdata->buttons[i];
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (button->wakeup) =
{
> > @@ -251,19 +251,27 @@ static int gpio_keys_resume(struct platform_d=
evice *pdev)
> >
> > =A0 =A0 =A0 =A0return 0;
> > =A0}
> > +
> > +static struct dev_pm_ops gpio_keys_pm_ops =3D {
> > + =A0 =A0 =A0 .suspend =A0 =A0 =A0 =A0=3D gpio_keys_suspend,
> > + =A0 =A0 =A0 .freeze =A0 =A0 =A0 =A0 =3D gpio_keys_suspend,
> > + =A0 =A0 =A0 .resume =A0 =A0 =A0 =A0 =3D gpio_keys_resume,
> > + =A0 =A0 =A0 .thaw =A0 =A0 =A0 =A0 =A0 =3D gpio_keys_resume,
>=20
> I'm not sure I understand hibernation correctly, but isn't
> .freeze/.thaw about saving state and halting/resuming the device
> operation only?
> It seems to me that enabling system wakeup functionality should go
> into .poweroff. (See <linux/pm.h>)

=46rankly, I'm not sure either. But luckily, the linux-pm list is copie=
d
so someone can elborate on this :)

Daniel