From: Anton Blanchard <anton@samba.org>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Zhaolei <zhaolei@cn.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] ftrace: add tracepoint for timer
Date: Thu, 6 Aug 2009 12:48:04 +1000 [thread overview]
Message-ID: <20090806024804.GB4685@kryten> (raw)
In-Reply-To: <4A7A4153.3040207@cn.fujitsu.com>
Hi,
> Example ftrace output:
> insmod-1712 [000] 145.901459: timer_init: timer=d0ace4b4
> insmod-1712 [000] 145.901469: timer_start: timer=d0ace4b4 func=timer_fun expires=4294813629 timeout=199
> <idle>-0 [000] 146.100230: timer_cancel: timer=d0ace4b4
> <idle>-0 [000] 146.100233: timer_expire: timer=d0ace4b4 jiffies=4294813629
> <idle>-0 [000] 146.100627: timer_callback_done: func=d0ace4b4
Sorry I haven't followed the thread, but I was wondering why you changed
the name of the entry and exit tracepoints (ie timer_entry/timer_exit).
I think consistent naming is important to match the other static
tracepoints, such as softirq_entry/softirq_exit, irq_entry/irq_exit and
tasklet_entry/tasklet_exit.
Anton
next prev parent reply other threads:[~2009-08-06 2:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 2:34 [PATCH v5 1/3] ftrace: add tracepoint for timer Xiao Guangrong
2009-08-06 2:36 ` [PATCH v5 2/3] ftrace: add tracepoint for hrtimer Xiao Guangrong
2009-08-06 2:38 ` [PATCH v5 3/3] ftrace: add tracepoint for itimer Xiao Guangrong
2009-08-06 2:48 ` Anton Blanchard [this message]
2009-08-06 3:21 ` [PATCH v5 1/3] ftrace: add tracepoint for timer Xiao Guangrong
2009-08-07 10:56 ` Ingo Molnar
2009-08-07 12:09 ` Xiao Guangrong
2009-08-07 14:16 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806024804.GB4685@kryten \
--to=anton@samba.org \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.