From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [pvops-dom0] Adding MCA logging support in pv_ops Date: Thu, 6 Aug 2009 09:27:04 +0200 Message-ID: <200908060927.05183.Christoph.Egger@amd.com> References: <200908051116.18270.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Ke, Liping" Cc: "jeremy@goop.org" , "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Thursday 06 August 2009 03:37:39 Ke, Liping wrote: > Hi, Christoph > Since we can't keep the same copy of header files for pv-ops and XEN > already, When sync back the header to XEN, I will only sync back the > modified comments and other required changes. As for the change for > programming conventions (inline function vs micro), I will not put them > back to XEN. Is it OK for you? Yes, that's fine. > > As for the union structure for recovery action, since no one is using it > now,I plan firstly to add a comment on it, something like "If more than > one kind of recovery action perbank permited, union structure need to > be changed". How do you think about it? That's fine with me. Tnx. Christoph > Thanks a lot! > Criping > > Christoph Egger wrote: > > On Wednesday 05 August 2009 03:57:20 Ke, Liping wrote: > >> Hi, Christoph > >> Please see my below comments. > >> > >> And also, I found some interfaces are different in pv_ops kernel > >> such as GUEST_HANDLE related. Seems we can't keep the same copy of > >> common > >> file between XEN and GUEST. > > > > That's not a problem as long as the ABI doesn't change. > > > >> We have to do slight changes to the XEN file before copying it to > >> guest kernel. > > > > Well, the comment updates I suppose. > > > >> And also, for the header file, I modified a little according to > >> Andi's feedback such as gigantic macros will be unacceptable > >> according to kernel code conventions, etc. So I modify > >> x86_mcinfo_lookup into inline function. > > > > NetBSD also has some "local" guest header changes which aren't > > accepted > > by Keir due to Xen conventions. > > Keep in mind that you have to merge the headers whenever you sync up > > with Xen. > > > >> I will resend the new patch to all of you for further feedback. > >> After the patch is accepted, I will sync the modified head file back > >> to XEN for consistency. > > > > Please practise friendly actions for non-Linux guests when changing > > the headers. Changing the macros for only one guest isn't a friendly > > action for all guests. > > > > Please only sync back the comment updates. > > > > If NetBSD, Solaris and Linux were trying to have all local changes in > > Xen headers, they would become a mess. > > > >> Thanks a lot for your help! > >> Criping -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632