From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH] perf_counter/powerpc: Check oprofile_cpu_type for NULL before using it
Date: Thu, 6 Aug 2009 13:55:53 +0200 [thread overview]
Message-ID: <20090806115553.GA10734@elte.hu> (raw)
In-Reply-To: <19066.48028.446975.501454@cargo.ozlabs.ibm.com>
* Paul Mackerras <paulus@samba.org> wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> If the current CPU doesn't support performance counters,
> cur_cpu_spec->oprofile_cpu_type can be NULL. The current perf_counter
> modules don't test for that case and would thus crash at boot time.
>
> Bug reported by David Woodhouse.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Reported-by: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> Ingo, this needs to go in for .31 since it fixes a boot-time oops.
> Are you going to be sending a batch to Linus shortly or should I send
> this to him separately?
Yeah, wanted to send a batch of fixes later today - so i've queued
this one up too in perfcounters/urgent.
Thanks,
Ingo
next parent reply other threads:[~2009-08-06 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19066.48028.446975.501454@cargo.ozlabs.ibm.com>
2009-08-06 11:55 ` Ingo Molnar [this message]
2009-08-06 11:57 ` [tip:perfcounters/urgent] perf_counter/powerpc: Check oprofile_cpu_type for NULL before using it tip-bot for Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806115553.GA10734@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.