From: Vincent Pelletier <plr.vincent@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: net/r8169.c: harmless (?) dupe
Date: Thu, 6 Aug 2009 13:17:03 +0200 [thread overview]
Message-ID: <200908061317.03652.plr.vincent@gmail.com> (raw)
Hi.
I was searching for rtl8102 support state in the kernel, and reading the
commit[1] adding support I saw this:
+#define R810X_CPCMD_QUIRK_MASK (\
+ EnableBist | \
+ Mac_dbgo_oe | \
+ Force_half_dup | \
+ Force_half_dup | \ <- dupe
+ Force_txflow_en | \
+ Cxpl_dbg_sel | \
If it is harmless by itself, wouldn't it indicate a missing Force_rxflow_en
(as in R8168_CPCMD_QUIRK_MASK) ?
I don't have the card yet, so this is no bug report, just wondering.
[1] 2857ffb7b8913ef713533ac5783abd70a20529e4
PS: Please CC me when answering, I'm not subscribed.
--
Vincent Pelletier
reply other threads:[~2009-08-06 11:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908061317.03652.plr.vincent@gmail.com \
--to=plr.vincent@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.