From: "John W. Linville" <linville@tuxdriver.com>
To: Dave Jones <davej@redhat.com>, Greg KH <greg@kroah.com>,
Marcel Holtmann <marcel@holtmann.org>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
zhifeng.cai@atheros.com, stephen.chen@atheros.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] pci_ids.h: add new Atheros USB vendor ID
Date: Thu, 6 Aug 2009 14:16:26 -0400 [thread overview]
Message-ID: <20090806181626.GF26809@tuxdriver.com> (raw)
In-Reply-To: <20090806181546.GA11589@redhat.com>
On Thu, Aug 06, 2009 at 02:15:46PM -0400, Dave Jones wrote:
> On Wed, Aug 05, 2009 at 10:09:32PM -0700, Greg Kroah-Hartman wrote:
> > > the closest we have is drivers/hid/hid-ids.h and we might just should
> > > have Greg create a usb-ids.h file.
> >
> > Ick, no, there's no such file for a good reason. Put your device ids in
> > the driver files, no need to share it across the whole kernel.
>
> I agree. In fact, I'd go further, and say that the bulk of what we have
> in pci_ids.h is also pointlessly shared. Only a tiny fraction of the device
> entries in that file are used by multiple files in the kernel.
Not much point in duplicating the vendor IDs among drivers. I agree
that sharing the device IDs has no obvious benefit.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-08-06 18:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 1:59 [PATCH] pci_ids.h: add new Atheros USB vendor ID Luis R. Rodriguez
2009-08-06 4:16 ` Marcel Holtmann
2009-08-06 4:26 ` Luis R. Rodriguez
2009-08-06 4:35 ` Marcel Holtmann
2009-08-06 5:09 ` Greg KH
2009-08-06 6:17 ` Marcel Holtmann
2009-08-06 18:15 ` Dave Jones
2009-08-06 18:16 ` John W. Linville [this message]
2009-08-06 18:33 ` Greg KH
2009-08-06 19:13 ` [PATCH] Document pci_ids.h addition policy Dave Jones
2009-08-06 19:16 ` John W. Linville
2009-08-06 19:38 ` Greg KH
2009-08-10 16:28 ` Jesse Barnes
2009-08-06 18:50 ` [PATCH] pci_ids.h: add new Atheros USB vendor ID Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090806181626.GF26809@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davej@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=marcel@holtmann.org \
--cc=stephen.chen@atheros.com \
--cc=zhifeng.cai@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.