From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 09/12] sendfile: several fixes
Date: Thu, 6 Aug 2009 19:29:44 -0400
Message-ID: <20090806232944.GA11804@infradead.org>
References: <200908062310.n76NAFKE012978@imap1.linux-foundation.org> <20090806232418.GA6279@infradead.org> <21c5ff280908061625g3752644dy6c685979312a4b5d@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>, akpm@linux-foundation.org,
	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	msb@google.com
To: Robert Love <rlove@google.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:42255 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752759AbZHFX3q (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 6 Aug 2009 19:29:46 -0400
Content-Disposition: inline
In-Reply-To: <21c5ff280908061625g3752644dy6c685979312a4b5d@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Aug 06, 2009 at 07:25:56PM -0400, Robert Love wrote:
> On Thu, Aug 6, 2009 at 7:24 PM, Christoph Hellwig<hch@infradead.org> wrote:
> 
> > The right fix is to not set s_maxbytes to ~0ULL. ?Jeff Layton has sent
> > some patches for that recently.
> 
> I agree.
> 
> I still think this check is worthwhile, given the signed/unsigned mismatch.

I think the plan is to change s_maxbytes to be an loff_t which would
eliminate this.  I'm not sure if Jeff has sent that patch already.