From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [patch 09/12] sendfile: several fixes Date: Fri, 7 Aug 2009 07:29:19 -0400 Message-ID: <20090807072919.06bc6770@tlielax.poochiereds.net> References: <200908062310.n76NAFKE012978@imap1.linux-foundation.org> <20090806232418.GA6279@infradead.org> <21c5ff280908061625g3752644dy6c685979312a4b5d@mail.gmail.com> <20090806232944.GA11804@infradead.org> <20090807061216.GX24668@google.com> <20090806232655.b40f8191.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Mandeep Singh Baines , Christoph Hellwig , Robert Love , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56785 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbZHGL3b (ORCPT ); Fri, 7 Aug 2009 07:29:31 -0400 In-Reply-To: <20090806232655.b40f8191.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 6 Aug 2009 23:26:55 -0700 Andrew Morton wrote: > On Thu, 6 Aug 2009 23:12:17 -0700 Mandeep Singh Baines wrote: > > > Christoph Hellwig (hch@infradead.org) wrote: > > > On Thu, Aug 06, 2009 at 07:25:56PM -0400, Robert Love wrote: > > > > On Thu, Aug 6, 2009 at 7:24 PM, Christoph Hellwig wrote: > > > > > > > > > The right fix is to not set s_maxbytes to ~0ULL. ?Jeff Layton has sent > > > > > some patches for that recently. > > > > > > > > Yeah, found it here: > > > > http://lkml.org/lkml/2009/7/22/178 > > > > > > I agree. > > > > > > > > I still think this check is worthwhile, given the signed/unsigned mismatch. > > > > > > I think the plan is to change s_maxbytes to be an loff_t which would > > > eliminate this. I'm not sure if Jeff has sent that patch already. > > > > > > > Yeah, found the discussion here: > > > > http://lkml.org/lkml/2009/7/22/241 > > > > Cool. Didn't really like this check. It would be nice to remove the check > > and comment from the next version of this patch. > > Jeff, can you please redo/refresh/review/resend that stuff? > Yep. I'll try to have something next week. The tricky part here is checking all of the existing filesystems and making sure that changing s_maxbytes to loff_t won't break anything. I also want to clean up the checks in do_sendfile like Johannes suggested, though I still have some questions about that... -- Jeff Layton