From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MZOX5-0001Ay-52 for mharc-grub-devel@gnu.org; Fri, 07 Aug 2009 08:26:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZOX3-00019A-F9 for grub-devel@gnu.org; Fri, 07 Aug 2009 08:26:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZOWz-000166-QS for grub-devel@gnu.org; Fri, 07 Aug 2009 08:26:49 -0400 Received: from [199.232.76.173] (port=49283 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZOWz-00015l-FS for grub-devel@gnu.org; Fri, 07 Aug 2009 08:26:45 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:40179 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MZOWy-0005yr-OM for grub-devel@gnu.org; Fri, 07 Aug 2009 08:26:45 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MZO2t-0004qA-KD for grub-devel@gnu.org; Fri, 07 Aug 2009 13:55:39 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MZO2s-0001xI-UE for grub-devel@gnu.org; Fri, 07 Aug 2009 13:55:38 +0200 Date: Fri, 7 Aug 2009 13:55:38 +0200 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20090807115538.GA7428@thorin> References: <20090804184225.GA14386@thorin> <20090804191351.GA14651@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090804191351.GA14651@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] fix FreeBSD.vfs.root.mountfrom X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2009 12:26:50 -0000 Committed. On Tue, Aug 04, 2009 at 09:13:51PM +0200, Robert Millan wrote: > On Tue, Aug 04, 2009 at 08:42:25PM +0200, Robert Millan wrote: > > > > FreeBSD.vfs.root.mountfrom expects an absolute path, not just device name. > > Actually, both work, but the former is what their loader uses, and it's > simpler for us to handle, so let's juse use that. > > Also, the default setting on FreeBSD is to mount / as writable, for which > we need vfs.root.mountfrom.options=rw. > > See new patch. > > -- > Robert Millan > > The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and > how) you may access your data; but nobody's threatening your freedom: we > still allow you to remove your data and not access it at all." > 2009-08-04 Robert Millan > > * util/grub.d/10_freebsd.in: Use an absolute device path for > `vfs.root.mountfrom'. Set `vfs.root.mountfrom.options=rw'. > > Index: util/grub.d/10_freebsd.in > =================================================================== > --- util/grub.d/10_freebsd.in (revision 2466) > +++ util/grub.d/10_freebsd.in (working copy) > @@ -50,8 +50,6 @@ if [ "x$kfreebsd" != "x" ] ; then > devices_rel_dirname=`make_system_path_relative_to_its_root $devices_dirname` > fi > > - root_device=`basename ${GRUB_DEVICE}` > - > # For "ufs" it's the same. Do we care about the others? > kfreebsd_fs=${GRUB_FS} > > @@ -69,7 +67,8 @@ EOF > EOF > fi > cat << EOF > - set FreeBSD.vfs.root.mountfrom=${kfreebsd_fs}:${root_device} > + set FreeBSD.vfs.root.mountfrom=${kfreebsd_fs}:${GRUB_DEVICE} > + set FreeBSD.vfs.root.mountfrom.options=rw > } > EOF > fi > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."