From: Ingo Molnar <mingo@elte.hu>
To: mingo@redhat.com, hpa@zytor.com, dvhltc@us.ibm.com,
linux-kernel@vger.kernel.org, jkacur@redhat.com,
johnstul@us.ibm.com, peterz@infradead.org, dino@in.ibm.com,
rostedt@goodmis.org, stable@kernel.org, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/urgent] futex: Update woken requeued futex_q lock_ptr
Date: Sun, 9 Aug 2009 22:56:11 +0200 [thread overview]
Message-ID: <20090809205611.GA23276@elte.hu> (raw)
In-Reply-To: <tip-4047446de8fa83d8d5922e9448eb0cbb7ac3f475@git.kernel.org>
* tip-bot for Darren Hart <dvhltc@us.ibm.com> wrote:
> @@ -1030,6 +1034,11 @@ void requeue_pi_wake_futex(struct futex_q *q, union futex_key *key)
> WARN_ON(!q->rt_waiter);
> q->rt_waiter = NULL;
>
> + q->lock_ptr = &hb->lock;
> +#ifdef CONFIG_DEBUG_PI_LIST
> + q->list.plist.slock = &hb->lock;
> +#endif
> +
> wake_up_state(q->task, TASK_NORMAL);
> }
>
-tip testing found a build error with v2 of the patch:
kernel/futex.c: In function ‘requeue_pi_wake_futex’:
kernel/futex.c:1039: error: ‘struct plist_head’ has no member named ‘slock’
Ingo
next prev parent reply other threads:[~2009-08-09 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 21:58 [PATCH 0/2] futex: requeue_pi lock steal deadlock fixes Darren Hart
2009-08-05 22:02 ` [PATCH 1/2] Update woken requeued futex_q lock_ptr Darren Hart
2009-08-06 5:15 ` Darren Hart
2009-08-07 0:24 ` Darren Hart
2009-08-08 15:27 ` [tip:core/urgent] futex: " tip-bot for Darren Hart
2009-08-09 20:24 ` tip-bot for Darren Hart
2009-08-09 20:56 ` Ingo Molnar [this message]
2009-08-09 22:03 ` Darren Hart
2009-08-09 22:18 ` Darren Hart
2009-08-05 22:04 ` [PATCH 2/2][RT] Avoid deadlock in rt_mutex_start_proxy_lock() Darren Hart
2009-08-05 22:04 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090809205611.GA23276@elte.hu \
--to=mingo@elte.hu \
--cc=dino@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.