From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Mike McCormack <mikem@ring3k.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: Create buffer alloc and free helpers
Date: Mon, 10 Aug 2009 08:29:43 -0700 [thread overview]
Message-ID: <20090810082943.3d389e8a@nehalam> (raw)
In-Reply-To: <4A7EB5A0.3040401@ring3k.org>
On Sun, 09 Aug 2009 20:40:16 +0900
Mike McCormack <mikem@ring3k.org> wrote:
> Refactor similar two sections of code that free buffers into one.
> As a side effect, only call tx_init() in sky2_up() if all buffer
> allocations succeed.
>
> Signed-off-by: Mike McCormack <mikem@ring3k.org>
> + if (0 > sky2_alloc_buffers(sky2))
> goto err_out;
Don't change code style. Especially in mid driver.
Just return 0 for success and errno or -1.
next prev parent reply other threads:[~2009-08-10 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-09 11:40 [PATCH] sky2: Create buffer alloc and free helpers Mike McCormack
2009-08-10 15:29 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-09-01 13:21 Mike McCormack
2009-09-02 0:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810082943.3d389e8a@nehalam \
--to=shemminger@linux-foundation.org \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.