From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MaTBa-0002Jf-CJ for mharc-grub-devel@gnu.org; Mon, 10 Aug 2009 07:37:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaTBY-0002JJ-78 for grub-devel@gnu.org; Mon, 10 Aug 2009 07:37:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaTBS-0002J1-Oi for grub-devel@gnu.org; Mon, 10 Aug 2009 07:37:02 -0400 Received: from [199.232.76.173] (port=39429 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaTBS-0002Iy-Lq for grub-devel@gnu.org; Mon, 10 Aug 2009 07:36:58 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:44356 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MaTBS-0005Vp-9w for grub-devel@gnu.org; Mon, 10 Aug 2009 07:36:58 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MaTBQ-000165-R8 for grub-devel@gnu.org; Mon, 10 Aug 2009 13:36:57 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MaTBQ-0002YM-87 for grub-devel@gnu.org; Mon, 10 Aug 2009 13:36:56 +0200 Date: Mon, 10 Aug 2009 13:36:56 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090810113656.GE9344@thorin> References: <20090804191940.GA14747@thorin> <20090807120529.GB7428@thorin> <1249709923.28996.35.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1249709923.28996.35.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] make 10_linux' test_gt() a bit more generic X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2009 11:37:04 -0000 On Sat, Aug 08, 2009 at 01:38:43AM -0400, Pavel Roskin wrote: > On Fri, 2009-08-07 at 14:05 +0200, Robert Millan wrote: > > > > Committed. Also moved those functions to grub-mkconfig_lib.in. > > When comparing vmlinuz-2.6.31-rc4-wl and vmlinuz-2.6.31-rc5-wl, > version_test_gt() ends up comparing "wl" and "wl". > > Using the "g" modifier leads to the replacement being applied > continuously until the last minus is consumed. The use of "g" wasn't > warranted before, but it didn't have such effect. You're right. I tend to use "g" without thinking. I should be more careful with this. > I'm committing the fix. Thanks. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."