From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MaTNv-0000rf-Kr for mharc-grub-devel@gnu.org; Mon, 10 Aug 2009 07:49:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaTNt-0000qn-4b for grub-devel@gnu.org; Mon, 10 Aug 2009 07:49:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaTNo-0000mY-F6 for grub-devel@gnu.org; Mon, 10 Aug 2009 07:49:48 -0400 Received: from [199.232.76.173] (port=35123 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaTNo-0000mB-9v for grub-devel@gnu.org; Mon, 10 Aug 2009 07:49:44 -0400 Received: from mx20.gnu.org ([199.232.41.8]:39954) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MaTNn-00081x-Gv for grub-devel@gnu.org; Mon, 10 Aug 2009 07:49:44 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8] helo=aybabtu.com) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MaTNm-0000Nl-IP for grub-devel@gnu.org; Mon, 10 Aug 2009 07:49:42 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MaTNl-0001Jb-BS for grub-devel@gnu.org; Mon, 10 Aug 2009 13:49:41 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MaTNk-0002aT-PA for grub-devel@gnu.org; Mon, 10 Aug 2009 13:49:40 +0200 Date: Mon, 10 Aug 2009 13:49:40 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090810114940.GI9344@thorin> References: <20090810110102.GP11691@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090810110102.GP11691@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Improve handling of "keep" in gfxpayload X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2009 11:49:49 -0000 On Mon, Aug 10, 2009 at 12:01:02PM +0100, Colin Watson wrote: > If the user set "keep" in gfxpayload, as I understand it, that indicates > that they want the graphical mode set by GRUB to persist through to the > kernel. In order for this to actually work with Linux, we need to set up > the vid_mode boot parameter to indicate that it should keep the current > video mode, otherwise it'll just reset the mode to text at boot and > nothing much is gained. This patch fixes that. Nice catch, I wasn't aware an extra flag was needed. > Note that I'm explicitly not enabling GRUB_ASSUME_LINUX_HAS_FB_SUPPORT > in the Ubuntu grub2 package. Actually, the Debian package stopped enabling it too. I had my reservations when "keep" was introduced, but now I see that Vladimir's idea is a much better option than hardcoding in the binary. I think I'll remove GRUB_ASSUME_LINUX_HAS_FB_SUPPORT. It seems that nobody is going to use it, so all it does is add complexity. This will also make your patch simpler. Is there any objection to that? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."