From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MaTWX-0004df-QN for mharc-grub-devel@gnu.org; Mon, 10 Aug 2009 07:58:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaTWV-0004dO-FH for grub-devel@gnu.org; Mon, 10 Aug 2009 07:58:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaTWQ-0004dB-41 for grub-devel@gnu.org; Mon, 10 Aug 2009 07:58:42 -0400 Received: from [199.232.76.173] (port=41603 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaTWP-0004d8-Tz for grub-devel@gnu.org; Mon, 10 Aug 2009 07:58:37 -0400 Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:39924) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MaTWP-0001Bt-DB for grub-devel@gnu.org; Mon, 10 Aug 2009 07:58:37 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MaTWO-0005yc-Dl for grub-devel@gnu.org; Mon, 10 Aug 2009 11:58:36 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1MaTWN-0002pe-00; Mon, 10 Aug 2009 12:58:35 +0100 Date: Mon, 10 Aug 2009 12:58:35 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20090810115835.GU11691@riva.ucam.org> References: <20090810110102.GP11691@riva.ucam.org> <20090810114940.GI9344@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090810114940.GI9344@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost03-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Improve handling of "keep" in gfxpayload X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2009 11:58:44 -0000 On Mon, Aug 10, 2009 at 01:49:40PM +0200, Robert Millan wrote: > On Mon, Aug 10, 2009 at 12:01:02PM +0100, Colin Watson wrote: > > If the user set "keep" in gfxpayload, as I understand it, that indicates > > that they want the graphical mode set by GRUB to persist through to the > > kernel. In order for this to actually work with Linux, we need to set up > > the vid_mode boot parameter to indicate that it should keep the current > > video mode, otherwise it'll just reset the mode to text at boot and > > nothing much is gained. This patch fixes that. > > Nice catch, I wasn't aware an extra flag was needed. It also seems that doing this right is tricky on the kernel side (see https://lists.ubuntu.com/archives/kernel-team/2009-August/006773.html and thread), so I probably won't be turning this on by default yet in our configuration - but of course if you explicitly say "keep" then you should get what you asked for. > > Note that I'm explicitly not enabling GRUB_ASSUME_LINUX_HAS_FB_SUPPORT > > in the Ubuntu grub2 package. > > Actually, the Debian package stopped enabling it too. I had my reservations > when "keep" was introduced, but now I see that Vladimir's idea is a much > better option than hardcoding in the binary. > > I think I'll remove GRUB_ASSUME_LINUX_HAS_FB_SUPPORT. It seems that nobody > is going to use it, so all it does is add complexity. This will also make > your patch simpler. > > Is there any objection to that? Not from me at least. Thanks, -- Colin Watson [cjwatson@ubuntu.com]