All of lore.kernel.org
 help / color / mirror / Atom feed
From: iceberg <strakh@ispras.ru>
To: linux-kernel@vger.kernel.org
Subject: BUG memory leakage at ./security/selinux/hooks.c
Date: Mon, 10 Aug 2009 12:57:43 +0400	[thread overview]
Message-ID: <200908101257.43672.strakh@ispras.ru> (raw)

        KERNEL_VERSION: 2.6.30.4
        SUBJECT:  in function inode_doinit_with_dentry memory is not released 
on error  path (if rc<0).
        DESCRIBE:
        In ./security/selinux/hooks.c in function inode_doinit_with_dentry:
1. If in the line 1278 we successfully allocate memory and assign it to 
context variablehen
2. if in the line 1284 getxattr returns -ERANGE and
3. if in the line 1288 getxattr returns rc<0
then we go to out_unlock without releasing memory pointed to by context 
variable.

1278                 context = kmalloc(len, GFP_NOFS);
1279                 if (!context) {
1280                         rc = -ENOMEM;
1281                         dput(dentry);
1282                         goto out_unlock;
1283                 }
1284                 rc = inode->i_op->getxattr(dentry, XATTR_NAME_SELINUX,
1285                                            context, len);
1286                 if (rc == -ERANGE) {
1287                         /* Need a larger buffer.  Query for the
right size. */
1288                         rc = inode->i_op->getxattr(dentry,
XATTR_NAME_SELINUX,
1289                                                    NULL, 0);
1290                         if (rc < 0) {
1291                                 dput(dentry);
1292                                 goto out_unlock;
1293                         }
1294                         kfree(context);
1295                         len = rc;
1296                         context = kmalloc(len, GFP_NOFS);



             reply	other threads:[~2009-08-10  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-10  8:57 iceberg [this message]
2009-08-10 11:53 ` BUG memory leakage at ./security/selinux/hooks.c James Morris
2009-08-10 11:53   ` James Morris
2009-08-10 12:17   ` [PATCH] SELinux: re. " James Morris
2009-08-10 12:17     ` James Morris
2009-08-10 12:24     ` Stephen Smalley
2009-08-10 12:24       ` Stephen Smalley
  -- strict thread matches above, loose matches on Subject: below --
2009-08-10  8:53 iceberg
2009-08-15  7:17 ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908101257.43672.strakh@ispras.ru \
    --to=strakh@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.