From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Michael Buesch <mb@bu3sch.de>, Daniel Mack <daniel@caiaq.de>,
"John W. Linville" <linville@tuxdriver.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Libertas: Association request to the driver failed
Date: Mon, 10 Aug 2009 18:04:14 +0400 [thread overview]
Message-ID: <20090810140414.GA5207@lenovo> (raw)
In-Reply-To: <4A7FF84C.7070708@gmail.com>
[Roel Kluin - Mon, Aug 10, 2009 at 12:37:00PM +0200]
...
| > I saw one pattern in trace code (not sure if it's
| > still there) but personally don't like dynamic
| > stack arrays (though at moment the max value
| > being passed into routine is known maybe just
| > use MAX_RATES instead of (*rates_size)?). Hmm?
|
| Good point.
|
| > -- Cyrill
|
| Thanks,
|
| I think there was another problem in lbs_associate(),
| the memcpy already affected rates->rates.
|
Yeah, something like that. Note that I was only cared about
stack so I didn't dive into details of this code :)
I suppose wireless mainteiners will review it more
precisely. Thanks Roel!
-- Cyrill
next prev parent reply other threads:[~2009-08-10 14:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 19:11 Libertas: Association request to the driver failed Daniel Mack
2009-08-07 19:36 ` John W. Linville
2009-08-07 20:50 ` Marek Vasut
2009-08-08 12:35 ` Daniel Mack
2009-08-08 14:24 ` Roel Kluin
2009-08-09 9:23 ` Roel Kluin
2009-08-09 10:24 ` Daniel Mack
2009-08-09 11:11 ` Roel Kluin
2009-08-09 11:10 ` Michael Buesch
2009-08-09 19:13 ` Cyrill Gorcunov
2009-08-10 10:37 ` Roel Kluin
2009-08-10 14:04 ` Cyrill Gorcunov [this message]
2009-08-10 17:47 ` Daniel Mack
2009-08-12 8:17 ` Jonathan Cameron
2009-08-12 8:47 ` Jonathan Cameron
2009-08-12 16:16 ` Dan Williams
2009-08-10 17:59 ` John W. Linville
2009-08-11 7:02 ` Roel Kluin
2009-08-11 18:24 ` John W. Linville
2009-08-12 16:15 ` Dan Williams
2009-08-12 17:34 ` Dan Williams
2009-08-07 21:21 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810140414.GA5207@lenovo \
--to=gorcunov@gmail.com \
--cc=daniel@caiaq.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.