From: Michael Buesch <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Johannes Berg <johannes@sipsolutions.net>,
Broadcom Wireless <bcm43xx-dev@lists.berlios.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] b43: Update LP-PHY rev2+ baseband init to match the specs
Date: Mon, 10 Aug 2009 20:46:00 +0200 [thread overview]
Message-ID: <200908102046.00427.mb@bu3sch.de> (raw)
In-Reply-To: <4A806A19.2070209@gmail.com>
On Monday 10 August 2009 20:42:33 Gábor Stefanik wrote:
> +static void lpphy_save_dig_flt_state(struct b43_wldev *dev)
> +{
> + static const u16 addr[] = {
> + B43_PHY_OFDM(0xC1),
> + B43_PHY_OFDM(0xC2),
> + B43_PHY_OFDM(0xC3),
> + B43_PHY_OFDM(0xC4),
> + B43_PHY_OFDM(0xC5),
> + B43_PHY_OFDM(0xC6),
> + B43_PHY_OFDM(0xC7),
> + B43_PHY_OFDM(0xC8),
> + B43_PHY_OFDM(0xCF),
> + };
> +
> + static const u16 coeffs[] = {
> + 0xDE5E, 0xE832, 0xE331, 0x4D26,
> + 0x0026, 0x1420, 0x0020, 0xFE08,
> + 0x0008,
> + };
> +
> + struct b43_phy_lp *lpphy = dev->phy.lp;
> + int i;
> +
> + for (i = 0; i < 9; i++) {
Use ARRAY_SIZE, please.
> + lpphy->dig_flt_state[i] = b43_phy_read(dev, addr[i]);
> + b43_phy_write(dev, addr[i], coefs[i]);
> + }
> +}
> +
> +static void lpphy_restore_dig_flt_state(struct b43_wldev *dev)
> +{
> + static const u16 addr[] = {
> + B43_PHY_OFDM(0xC1),
> + B43_PHY_OFDM(0xC2),
> + B43_PHY_OFDM(0xC3),
> + B43_PHY_OFDM(0xC4),
> + B43_PHY_OFDM(0xC5),
> + B43_PHY_OFDM(0xC6),
> + B43_PHY_OFDM(0xC7),
> + B43_PHY_OFDM(0xC8),
> + B43_PHY_OFDM(0xCF),
> + };
> +
> + struct b43_phy_lp *lpphy = dev->phy.lp;
> + int i;
> +
> + for (i = 0; i < 9; i++)
Same here.
> + b43_phy_write(dev, addr[i], lpphy->dig_flt_state[i]);
> +}
> +
--
Greetings, Michael.
prev parent reply other threads:[~2009-08-10 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 18:42 [PATCH] b43: Update LP-PHY rev2+ baseband init to match the specs Gábor Stefanik
2009-08-10 18:46 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908102046.00427.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.