From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Why do we read the blocks in __ocfs2_xxattr_set_value_outside()?
Date: Tue, 11 Aug 2009 15:09:15 -0700 [thread overview]
Message-ID: <20090811220915.GF28478@mail.oracle.com> (raw)
In __ocfs2_xattr_set_value_outside(), we walk each block of the
xattr value and read it before we copy the new data on top and dirty it.
Why are we reading the block from disk if we're just overwriting it?
Would't "sb_getblk(); ocfs2_set_buffer_uptodate()" work better?
Joel
--
"This is the end, beautiful friend.
This is the end, my only friend the end
Of our elaborate plans, the end
Of everything that stands, the end
No safety or surprise, the end
I'll never look into your eyes again."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next reply other threads:[~2009-08-11 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 22:09 Joel Becker [this message]
2009-08-12 1:40 ` [Ocfs2-devel] Why do we read the blocks in __ocfs2_xxattr_set_value_outside()? Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811220915.GF28478@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.