From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mb1rA-0005lx-Kh for mharc-grub-devel@gnu.org; Tue, 11 Aug 2009 20:38:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mb1r8-0005lC-MU for grub-devel@gnu.org; Tue, 11 Aug 2009 20:38:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mb1r4-0005jX-8w for grub-devel@gnu.org; Tue, 11 Aug 2009 20:38:18 -0400 Received: from [199.232.76.173] (port=60108 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mb1r3-0005jP-SB for grub-devel@gnu.org; Tue, 11 Aug 2009 20:38:13 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:36210 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mb1r2-0005zQ-Qh for grub-devel@gnu.org; Tue, 11 Aug 2009 20:38:13 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mb1qx-0000Gm-7P for grub-devel@gnu.org; Wed, 12 Aug 2009 02:38:08 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mb1qq-0002G1-3H for grub-devel@gnu.org; Wed, 12 Aug 2009 02:38:00 +0200 Date: Wed, 12 Aug 2009 02:38:00 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090812003800.GC8561@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2009 00:38:19 -0000 On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. A bug was filed that embedding code in grub-setup.c was > ignoring partmap metadata which could cause its overwriting. To avoid > usage of metadata and because of upcoming sunpc embedding support I > propose to move embedding to partmap/*.c. For this I devised an > interface which enables future reusage of embedding for other too if > necessary. Can this go in util/i386/pc/ instead? This is basicaly ad-hoc code and doesn't seem very meaningful in generic partmap/*.c. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."