From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 2/8 v2] Maintain back mapping from irqchip/pin to gsi. Date: Wed, 12 Aug 2009 13:17:22 +0300 Message-ID: <20090812101722.GE4764@redhat.com> References: <1249993895-11119-1-git-send-email-gleb@redhat.com> <1249993895-11119-3-git-send-email-gleb@redhat.com> <4A8278D6.7080102@redhat.com> <20090812084245.GY4764@redhat.com> <4A828633.30903@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44513 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932405AbZHLKRX (ORCPT ); Wed, 12 Aug 2009 06:17:23 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7CAHOqk010096 for ; Wed, 12 Aug 2009 06:17:24 -0400 Content-Disposition: inline In-Reply-To: <4A828633.30903@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Aug 12, 2009 at 12:06:59PM +0300, Avi Kivity wrote: > On 08/12/2009 11:42 AM, Gleb Natapov wrote: >> >> >>> What's this? >>> >>> >> If there is not GSI mapping use pin as gsi. This what current code does. >> We can BUG() here I think. >> >> > > We can't BUG() userspace can change the mapping before the ack is received. > Yes. Malicious userspace can remove GSI mapping for GSI with ack notifier registered, so we can't BUG(). But making GSI=pin doesn't look correct too. Should we just skip calling ack notifier? -- Gleb.