From: Kalle Valo <kalle.valo@iki.fi>
To: linville@tuxdriver.com
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: [PATCH 1/3] mac80211: refactor dynamic power save check
Date: Wed, 12 Aug 2009 17:52:01 +0300 [thread overview]
Message-ID: <20090812145200.23691.17281.stgit@tikku> (raw)
From: Kalle Valo <kalle.valo@nokia.com>
Refactor dynamic power save checks to a function of it's own for better
readibility. No functional changes.
Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
---
net/mac80211/tx.c | 24 +++++++++++++++++++++---
1 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 10a1099..03005f9 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1384,6 +1384,26 @@ static int ieee80211_skb_resize(struct ieee80211_local *local,
return 0;
}
+static bool is_dynamic_ps_enabled(struct ieee80211_local *local)
+{
+ if (!(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK))
+ /* driver doesn't support power save */
+ return false;
+
+ if (local->hw.conf.dynamic_ps_timeout <= 0)
+ /* dynamic power save disabled */
+ return false;
+
+ if (local->scanning)
+ /* we are scanning, don't enable power save */
+ return false;
+
+ if (!local->ps_sdata)
+ return false;
+
+ return true;
+}
+
static void ieee80211_xmit(struct ieee80211_sub_if_data *sdata,
struct sk_buff *skb)
{
@@ -1396,9 +1416,7 @@ static void ieee80211_xmit(struct ieee80211_sub_if_data *sdata,
dev_hold(sdata->dev);
- if ((local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) &&
- local->hw.conf.dynamic_ps_timeout > 0 &&
- !(local->scanning) && local->ps_sdata) {
+ if (is_dynamic_ps_enabled(local)) {
if (local->hw.conf.flags & IEEE80211_CONF_PS) {
ieee80211_stop_queues_by_reason(&local->hw,
IEEE80211_QUEUE_STOP_REASON_PS);
next reply other threads:[~2009-08-12 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 14:52 Kalle Valo [this message]
2009-08-12 14:52 ` [PATCH 2/3] mac80211: fix dynamic power save for devices which have nullfunc support Kalle Valo
2009-08-12 15:03 ` Johannes Berg
2009-08-12 18:57 ` Kalle Valo
2009-08-12 14:52 ` [PATCH 3/3] wl1251: enable power save Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812145200.23691.17281.stgit@tikku \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.