From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [PATCH JGIT 2/5] FileMode: Store bit masks in int constants
Date: Wed, 12 Aug 2009 08:22:52 -0700 [thread overview]
Message-ID: <20090812152252.GE1033@spearce.org> (raw)
In-Reply-To: <1250089776-22895-1-git-send-email-fonseca@diku.dk>
Jonas Fonseca <fonseca@diku.dk> wrote:
> + public static final int TYPE_MASK = 0170000;
> + public static final int TREE_MASK = 0040000;
> + public static final int SYMLINK_MASK = 0120000;
> + public static final int FILE_MASK = 0100000;
> + public static final int GITLINK_MASK = 0160000;
> + public static final int MISSING_MASK = 0000000;
These last 5 entries aren't masks, they are type codes. I'd rather
they be called FOO_TYPE than FOO_MASK. In particular what is really
troubling is MISSING_MASK, being all 0 it always destroys the input
and then matches everything. :-)
I'm going to amend this name change in here, s/_MASK/_TYPE/ on the
last 5 fields.
--
Shawn.
prev parent reply other threads:[~2009-08-12 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 14:33 [PATCH JGIT 2/5] FileMode: Store bit masks in int constants Jonas Fonseca
2009-08-12 15:09 ` Jonas Fonseca
2009-08-12 15:22 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812152252.GE1033@spearce.org \
--to=spearce@spearce.org \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.