From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Barry Song <21cnbao@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/3] new board driver to connect bfin-5xx with ad1836 codec
Date: Wed, 12 Aug 2009 17:10:20 +0100 [thread overview]
Message-ID: <20090812161020.GE11898@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1250051574-25119-4-git-send-email-21cnbao@gmail.com>
On Wed, Aug 12, 2009 at 12:32:54PM +0800, Barry Song wrote:
This is OK but...
> + /* set cpu DAI slots, 8 channels, mask is defined as slot seq */
> + ret = snd_soc_dai_set_tdm_slot(cpu_dai, 0x73625140, 8);
> + if (ret < 0)
> + return ret;
This suggests that there's something really odd going on with your
set_tdm_slot() for the CPU which is likely to make it incompatible with
other implementations and with any core support to handle things like
multi-drop DAIs. The DAI driver side could certainly use more
documenation explaining what's going on if nothing else...
next prev parent reply other threads:[~2009-08-12 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 4:32 [PATCH 0/3] patch sequence adds analog devices ad1836 asoc support Barry Song
2009-08-12 4:32 ` [PATCH 1/3] new ad1836 codec driver based on asoc Barry Song
2009-08-12 4:32 ` [PATCH 2/3] add set_tdm_slot in tdm dai to define the relationship between audio channel and tdm slot Barry Song
2009-08-12 4:32 ` [PATCH 3/3] new board driver to connect bfin-5xx with ad1836 codec Barry Song
2009-08-12 16:10 ` Mark Brown [this message]
2009-08-13 4:19 ` Barry Song
2009-08-12 13:56 ` [PATCH 2/3] add set_tdm_slot in tdm dai to define the relationship between audio channel and tdm slot Mark Brown
2009-08-13 4:16 ` Barry Song
2009-08-12 13:46 ` [PATCH 1/3] new ad1836 codec driver based on asoc Mark Brown
2009-08-13 3:41 ` Barry Song
2009-08-13 9:08 ` Mark Brown
2009-08-13 9:22 ` [Uclinux-dist-devel] " Mike Frysinger
2009-08-13 9:34 ` Mike Frysinger
2009-08-13 9:37 ` Barry Song
2009-08-13 9:46 ` Mark Brown
2009-08-13 9:52 ` Barry Song
2009-08-13 10:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812161020.GE11898@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.