From: "Shawn O. Pearce" <spearce@spearce.org>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/4] fast-import: define a new option command
Date: Thu, 13 Aug 2009 10:52:11 -0700 [thread overview]
Message-ID: <20090813175211.GQ1033@spearce.org> (raw)
In-Reply-To: <fabb9a1e0908131044g583f126dm6a3818b4b295eaf5@mail.gmail.com>
Sverre Rabbelier <srabbelier@gmail.com> wrote:
> On Thu, Aug 13, 2009 at 10:41, Shawn O. Pearce<spearce@spearce.org> wrote:
> > Uh, no, if we have "option import-marks=..." and we can't find the
> > file "..." and we have no --import-marks command line flag that
> > would have overridden it, we need to abort with an error.
>
> Ah, then how about in option_import_marks() we only store the name of
> the file, like in option_export_marks, and at the end, when we reach
> the first non-option command (and we've parsed argv), we read the
> file. That way it's only read once, and it deals with the above
> scenario.
That's better. :-)
--
Shawn.
next prev parent reply other threads:[~2009-08-13 17:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 5:09 [PATCH 0/4] fast-import: add a new option command Sverre Rabbelier
2009-08-13 5:09 ` [PATCH 1/4] fast-import: put option parsing code in seperate functions Sverre Rabbelier
2009-08-13 5:09 ` [PATCH 2/4] fast-import: define a new option command Sverre Rabbelier
2009-08-13 5:09 ` [PATCH 3/4] fast-import: add " Sverre Rabbelier
2009-08-13 5:09 ` [PATCH 4/4] fast-import: test the new " Sverre Rabbelier
2009-08-13 14:45 ` [PATCH 3/4] fast-import: add " Shawn O. Pearce
2009-08-13 14:43 ` [PATCH 2/4] fast-import: define a new " Shawn O. Pearce
2009-08-13 14:56 ` Johannes Schindelin
2009-08-13 15:04 ` Shawn O. Pearce
[not found] ` <fabb9a1e0908130812s297ccfc6vd6b746daf1dcc69a@mail.gmail.com>
2009-08-13 15:24 ` Shawn O. Pearce
2009-08-13 16:26 ` Sverre Rabbelier
2009-08-13 17:07 ` Johannes Schindelin
2009-08-13 17:09 ` Sverre Rabbelier
2009-08-13 17:25 ` Shawn O. Pearce
2009-08-13 17:28 ` Sverre Rabbelier
2009-08-13 17:41 ` Shawn O. Pearce
2009-08-13 17:44 ` Sverre Rabbelier
2009-08-13 17:52 ` Shawn O. Pearce [this message]
2009-08-13 21:51 ` Johannes Schindelin
2009-08-13 22:01 ` Sverre Rabbelier
2009-08-13 22:12 ` Shawn O. Pearce
2009-08-13 22:17 ` Sverre Rabbelier
2009-08-13 19:26 ` Junio C Hamano
2009-08-13 20:01 ` Sverre Rabbelier
2009-08-13 20:42 ` Junio C Hamano
2009-08-13 21:14 ` Sverre Rabbelier
2009-11-23 17:39 ` Sverre Rabbelier
2009-11-23 20:50 ` Shawn O. Pearce
2009-08-13 10:19 ` [PATCH 1/4] fast-import: put option parsing code in seperate functions Johannes Schindelin
2009-08-13 14:40 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813175211.GQ1033@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.