From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mbh3X-0000pR-69 for mharc-grub-devel@gnu.org; Thu, 13 Aug 2009 16:37:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mbh3U-0000kv-FV for grub-devel@gnu.org; Thu, 13 Aug 2009 16:37:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mbh3P-0000cj-Vm for grub-devel@gnu.org; Thu, 13 Aug 2009 16:37:48 -0400 Received: from [199.232.76.173] (port=50062 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mbh3P-0000cV-IK for grub-devel@gnu.org; Thu, 13 Aug 2009 16:37:43 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:43934 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mbh3P-0006cJ-4L for grub-devel@gnu.org; Thu, 13 Aug 2009 16:37:43 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mbh3K-0000P5-SN for grub-devel@gnu.org; Thu, 13 Aug 2009 22:37:39 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mbh3I-0005xW-Tn for grub-devel@gnu.org; Thu, 13 Aug 2009 22:37:36 +0200 Date: Thu, 13 Aug 2009 22:37:36 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090813203736.GH22130@thorin> References: <20090812003800.GC8561@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 20:37:48 -0000 On Wed, Aug 12, 2009 at 02:52:12PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Aug 12, 2009 at 2:38 AM, Robert Millan wrote: > > On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Hello. A bug was filed that embedding code in grub-setup.c was > >> ignoring partmap metadata which could cause its overwriting. To avoid > >> usage of metadata and because of upcoming sunpc embedding support I > >> propose to move embedding to partmap/*.c. For this I devised an > >> interface which enables future reusage of embedding for other too if > >> necessary. > > > > Can this go in util/i386/pc/ instead?  This is basicaly ad-hoc code and > > doesn't seem very meaningful in generic partmap/*.c. > We may want to embed more in the future. Actually I think it's not > ad-hoc. Basically partition map defines a function which gives back > the sectors available for embedding. Is embedding useful elsewhere? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."