From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MbhQC-0005WV-NM for mharc-grub-devel@gnu.org; Thu, 13 Aug 2009 17:01:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbhQB-0005TL-0M for grub-devel@gnu.org; Thu, 13 Aug 2009 17:01:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbhQ6-0005Oo-AJ for grub-devel@gnu.org; Thu, 13 Aug 2009 17:01:14 -0400 Received: from [199.232.76.173] (port=37814 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbhQ6-0005Oi-0a for grub-devel@gnu.org; Thu, 13 Aug 2009 17:01:10 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:38152 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MbhQ5-0002Kc-3e for grub-devel@gnu.org; Thu, 13 Aug 2009 17:01:09 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MbhQ2-0000Xp-MP for grub-devel@gnu.org; Thu, 13 Aug 2009 23:01:07 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MbhPz-00063s-Rh for grub-devel@gnu.org; Thu, 13 Aug 2009 23:01:03 +0200 Date: Thu, 13 Aug 2009 23:01:03 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090813210103.GQ22130@thorin> References: <20090813194103.GA22130@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Fwd: [PATCH 1/2] Framebuffer split X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 21:01:15 -0000 On Thu, Aug 13, 2009 at 10:36:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Please go ahead (I assume it raises no warnings and it's well tested). > I tested the latest version with gfxterm and xnu loader. I use > previous version in my daily bootloader. I'll run another series of > tests before comitting. > > > > One small detail: > > > >> +  grub_free (mode_list); > >> +  mode_list = 0; > > > > I would prefer if we used NULL for pointers.  I know we don't do that > > everywhere, but it makes code easier to understand. > >From GCS: "Zero without a cast is perfectly fine as a null pointer > constant, except when calling a varargs function. " Even if it's not mandated by GCS, it does make the code easier to read, because of the loaded meaning in this expression (just like 'A' can be more meaningful than 0x41). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."